Adopting Security Groups API V3 #1185
Closed
radoslav-tomov wants to merge 21 commits intocloudfoundry:mainfrom
Closed
Adopting Security Groups API V3 #1185radoslav-tomov wants to merge 21 commits intocloudfoundry:mainfrom
radoslav-tomov wants to merge 21 commits intocloudfoundry:mainfrom
Conversation
radoslav-tomov
changed the title
Gerg
requested review from
Gerg,
anthonydahanne,
dmikusa and
pivotal-david-osullivan
anthonydahanne
requested changes
Oct 4, 2023
Contributor
anthonydahanne
left a comment
anthonydahanne
left a comment
There was a problem hiding this comment.
all tests pass; I've had a quick look, please fix obvious issues (cf screenshots)
thank you
integration-test/src/test/java/org/cloudfoundry/client/v3/SecurityGroupsTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/reactor/client/v3/securitygroups/ReactorSecurityGroupsV3.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@anthonydahanne I've removed the unused imports and reformatted via the standard google eclipse style formatter. Fixed the year in the license comment and added it where it was missing. Unfortunately I don't have InteliJ license, so I might have missed some warnings. Let me know if this is the case. |
Contributor
|
Hello @radoslav-tomov ! But I don't blame you at all; the project should have a linter in place; working on that! |
Contributor
|
was included and merged with this PR #1215 |
Contributor
|
Closing as this work was included in #1215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopting Security Groups API V3 API. Change includes implementation, unit and integration tests for the following operations:
PR ended up a bit on the large side, but it is mostly boilerplate, so I decided not to try to brake it further apart.